Comment 14 for bug 631275

Revision history for this message
edso (ed.so) wrote : Re: [Bug 631275] Re: 0.6.09: rsync url parsing broken, but only with python 2.6

On 20.11.2010 06:08, az wrote:
> one other item re the rsync backend: is there a good reason for
> feeding the user part of an rsync uri via the env for rsyncd-module uris?
>
> rsync can deal fine with the username on the commandline for both ssh and rsyncd-modules,
> so the code to handle usernames separately seems unnecessary.

These strings show up in os process listings e.g. ps, which poses a security risk as other users might catch it. Hence we prefer to deliver them as env var if possible.

..ede/duply.net