Comment 6 for bug 1624725

Thanks Aaron!

On Sun, Nov 6, 2016 at 5:03 PM, Aaron Whitehouse <<email address hidden>
> wrote:

> I think that I have fixed this in the attached branch, but I would like
> to test it further before proposing a merge.
>
> --
> You received this bug notification because you are subscribed to
> Duplicity.
> https://bugs.launchpad.net/bugs/1624725
>
> Title:
> Including a folder ending in "/" does not include folder contents
>
> Status in Duplicity:
> In Progress
>
> Bug description:
> Including a folder with an --include ending in "/" does not include
> folder contents. Including the folder with the same --include without
> the "/" does include contents.
>
> As reported by Claus in Bug #1479545:
> "I had a command line similar to
> --include ~/very/important/stuff/here/needs/backup/ --exclude '**'
> Now of course I checked the backups when I set this up and everything
> was fine.
>
> Recently I noticed that backups are very fast (too fast for the amount
> of data) and found that all files are missing in the backup!
>
> By changing behavior back and forth you probably messed up a lot of
> backups everywhere and many users are probably not aware that their
> files are currently not in the backup!
>
> My suggestion on how to cleanup this mess:
> a) Change back once again (It is better there are to many files in
> backup than to little).
> b) Introduce an explicit switch e.g. "--include-dirs-only <your-dir>"
> for the old behavior
>
> At least point out this old/new very unintuitive behavior in the man
> page please.
>
> Sorry if this sounds a little harsh, I am not writing this to yell at
> people who are only trying to help others. But I am very concerned
> about users/admins having a data loss and then noticing their backups
> are useless."
>
> This bug was introduced at rev 1112 of the 0.7-series, though note
> that include and exclude lines including any globbing patterns
> (including *) were pretty fundamentally broken prior to rev 1110 (Bug
> #932482) anyway, so the main people who will be seeing a regression
> will be those who do not use globs in the relevant directory
> include/exclude line.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/duplicity/+bug/1624725/+subscriptions
>