Comment 2 for bug 1170161

One comment - the difftar files do not really have a prefix, and those are the ones most in need of a prefix. When setting up retention rules on s3 you set them on the files you want to move to glacier, not the ones you want to leave in s3.

I'd suggest adding a prefix of some kind to the difftar files.

Right now the tardiff files can be identified because they use a period instead of a hyphen after the common prefix (eg duplicity-full).

The current conventions are:
duplicity-inc-manifest.date
duplicity-inc-signatures.date
duplicity-inc.date

The resulting prefix would be "duplicity-inc." - only the period separates this from the manifests which might be kept online.

It would make more sense to name them:
duplicity-inc-manifest.date
duplicity-inc-signatures.date
duplicity-inc-difftar.date
(or some other prefix)

Otherwise your patch works fine for me.