Comment 2 for bug 1083439

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 1083439] Re: SSHGitClient doesn't support username expansion

On Thu, 2013-01-10 at 04:07 +0000, milki wrote:
> Implemented the suggested solution.
>
> No tests made because I am not sure of how to emulate the behaviour and
> there is no existing test for TCPGitClient.
>
> ** Patch added: "0001-Support-username-expansion-in-SSHGitClient.patch"
> https://bugs.launchpad.net/dulwich/+bug/1083439/+attachment/3478736/+files/0001-Support-username-expansion-in-SSHGitClient.patch
That looks reasonable to me - though a test would be really nice...

Cheers,

Jelmer