Comment 7 for bug 931917

Revision history for this message
Henrik Ingo (hingo) wrote :

Is there a commit missing? Everything looks fine but I don't see that t/basic.policy would have changed as you claim.

A few comments on the docs:

Important: These docs are published on docs.drizzle.org and the same manual should cover all versions of Drizzle. So you must write something like:

In Drizzle 7 and Drizzle 7.1 the action words ACCEPT and DENY were used. Beginning with Drizzle 7.2.0 [yeah, I'm assuming this is the version where this code is published, but you would of course update it if it is not merged as expected] you should use ALLOW and DENY, but also ACCEPT and REJECT are supported for backward compatibility.

[Then continue with examples using ALLOW/DENY as you now do.]

You could remove the Examples section completely. Since the "Regex Policy File Format" does contain an example, there is no need to apologize.