database name not included in RAW_SQL type in transaction_log

Bug #526812 reported by Joe Daly
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Drizzle
Won't Fix
High
Jay Pipes

Bug Description

doing the following

create table a (i int primary key)

results in the following in a Transaction message. If this were to be replicated it would cause a error as no database name is in the sql statement.

replicated message text=transaction_context {
  server_id: 1
  transaction_id: 41
  start_timestamp: 1266979792840979
  end_timestamp: 1266979792840991
}
statement {
  type: RAW_SQL
  start_timestamp: 1266979792840982
  end_timestamp: 1266979792840989
  sql: "create table a (i int primary key)"
}

Revision history for this message
Jay Pipes (jaypipes) wrote :

Yep, absolutely correct. I will work on this one. Slowly, RAW_SQL statements are being removed (and replaced with more specific message subclasses that better describe the statement) but in the meantime, it would be a pretty trivial fix to add in the schema name into the message.

Cheers!

Jay

Changed in drizzle:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Jay Pipes (jaypipes)
milestone: none → 2010-03-15
Revision history for this message
Brian Aker (brianaker) wrote : Re: [Bug 526812] Re: database name not included in RAW_SQL type in transaction_log

Hi!

It should be possible very soon to just send the schema proto over the
wire (and before April Table).

Cheers,
 -Brian
On Feb 24, 2010, at 6:26 AM, Jay Pipes wrote:

> Yep, absolutely correct. I will work on this one. Slowly, RAW_SQL
> statements are being removed (and replaced with more specific message
> subclasses that better describe the statement) but in the meantime, it
> would be a pretty trivial fix to add in the schema name into the
> message.
>
> Cheers!
>
> Jay
>
> ** Changed in: drizzle
> Status: New => Confirmed
>
> ** Changed in: drizzle
> Importance: Undecided => High
>
> ** Changed in: drizzle
> Assignee: (unassigned) => Jay Pipes (jaypipes)
>
> ** Changed in: drizzle
> Milestone: None => 2010-03-15
>
> --
> database name not included in RAW_SQL type in transaction_log
> https://bugs.launchpad.net/bugs/526812
> You received this bug notification because you are a member of
> Drizzle-
> developers, which is subscribed to Drizzle.
>
> Status in A Lightweight SQL Database for Cloud and Web: Confirmed
>
> Bug description:
> doing the following
>
> create table a (i int primary key)
>
> results in the following in a Transaction message. If this were to
> be replicated it would cause a error as no database name is in the
> sql statement.
>
> replicated message text=transaction_context {
> server_id: 1
> transaction_id: 41
> start_timestamp: 1266979792840979
> end_timestamp: 1266979792840991
> }
> statement {
> type: RAW_SQL
> start_timestamp: 1266979792840982
> end_timestamp: 1266979792840989
> sql: "create table a (i int primary key)"
> }
>
>

Revision history for this message
Jay Pipes (jaypipes) wrote :

Hi again, Joe.

OK, so I'm marking this won't fix b/c Brian actually has made excellent progress in the new schema engine, and it's actually easier now for me to start getting rid of RAW_SQL statements for most things, including the CREATE TABLE/ALTER TABLE statements.

Cheers,

Jay

Changed in drizzle:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.