Comment 1 for bug 1051742

Revision history for this message
Brendan (brenbarn) wrote :

I seem to have fixed this bug by changing two lines in the execute_source method in dreampielib/gui/__init__.py. The last two lines of the method are:

self.vadj_to_bottom.scroll_to_bottom()
self.set_is_executing(True)

I just switched the order of these two lines. My guess is that some sort of timing issue sometimes occurred during the redraw associated with scrolling to the bottom, where during the scroll it tried to do something believing it was executing, but it wasn't, because it hadn't reached the set_is_executing line. I saw that the code in crash_workaround.py was being triggered during these crashes. Switching the order of the two lines appears to fix it by ensuring that the code is marked as "executing" during the scroll. However, I don't understand the internals of what's going on here well enough to know if this is a real fix, or what really caused it.