OVSDB monitor reports events on irrelevant ports

Bug #1561517 reported by Omer Anson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DragonFlow
Fix Released
High
Omer Anson

Bug Description

OVSDB monitor reports events on irrelevant ports. For instance, ports of type router_gateway should not be handled.

Specifically, ports should be handled if and only if they are attached to br-int.

This was found as part of handling bug #1560923. The exception raised there is also due to this issue.

Changed in dragonflow:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to dragonflow (master)

Reviewed: https://review.openstack.org/296916
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=daba82c66cb6ed183f9cafb120ae70d850e20dde
Submitter: Jenkins
Branch: master

commit daba82c66cb6ed183f9cafb120ae70d850e20dde
Author: Omer Anson <email address hidden>
Date: Thu Mar 24 08:46:50 2016 +0200

    Do not add lport to db_store via topology

    Adding an lport to db_store is already done in the df controller, via
    logical_port_updated. That method also ensures that unrelated ports
    (e.g. router_gateway) are not added. If they are forcefully added
    anyway, unexpected behaviour occurs, since they don't have e.g. chassis,
    and network_id, set.

    Change-Id: I4aec58e0f7c1aa839f6da535c1b4b8f46885cc16
    Closes-Bug: 1560923
    Related-Bug: 1561517

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (master)

Reviewed: https://review.openstack.org/297188
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=0fe30b699dfce968a2b9ecce34a1a7022cfefab3
Submitter: Jenkins
Branch: master

commit 0fe30b699dfce968a2b9ecce34a1a7022cfefab3
Author: Omer Anson <email address hidden>
Date: Thu Mar 24 15:57:00 2016 +0200

    OVSDB monitor to filter port update events

    OVSDB monitor should only dispatch events for ports that are attached to
    the br-int bridge. The controller need not be notified of other ports.

    Change-Id: I2ef8a1a55a07f48f1a81852b3fb52fcfae99b49f
    Closes-Bug: 1561517

Changed in dragonflow:
status: In Progress → Fix Released
Revision history for this message
hujie (mike-hu) wrote :

Hi Omer, I have reviewed your code about this bug, I have a question, when ovsdb monitor receive the notify message from ovsdb, how could you make sure that the port info has been stored in the IDL cache?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.