delete router gateway port: TypeError in l2_app

[Li Ma]

http://logs.openstack.org/11/296311/1/check/gate-dragonflow-dsvm-fullstack-nv/a8370be/logs/screen-df-controller.txt.gz

2016-03-23 09:52:17.703 10003 INFO dragonflow.controller.df_local_controller [-] Removing remote Logical Port = {u'parent_name': None, u'macs': [u'fa:16:3e:ce:e2:3e'], u'name': u'dc9a2aeb-c37b-42c3-bb04-6cd97fdb6bc4', u'lswitch': u'c4ad36e0-4027-4299-bb55-3645238f4869', u'port_security': [u'fa:16:3e:ce:e2:3e'], u'enabled': True, u'topic': u'', u'ips': [u'172.24.5.4', u'2001:db8::4'], u'device_owner': u'network:router_gateway', u'chassis': None, u'sgids': None, u'tunnel_key': 28, u'external_ids': {u'neutron:port_name': u''}, u'tag': None, u'security_groups': None}{}
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb [-] unsupported operand type(s) for &: 'NoneType' and 'long'
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb Traceback (most recent call last):
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb File "/opt/stack/new/dragonflow/dragonflow/db/api_nb.py", line 154, in _read_db_changes_from_queue
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb value)
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb File "/opt/stack/new/dragonflow/dragonflow/db/api_nb.py", line 179, in apply_db_change
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb self.controller.logical_port_deleted(lport_id)
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb File "/opt/stack/new/dragonflow/dragonflow/controller/df_local_controller.py", line 244, in logical_port_deleted
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb self.open_flow_app.notify_remove_remote_port(lport)
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb File "/opt/stack/new/dragonflow/dragonflow/controller/ryu_base_app.py", line 89, in notify_remove_remote_port
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb self.dispatcher.dispatch('remove_remote_port', lport=lport)
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb File "/opt/stack/new/dragonflow/dragonflow/controller/dispatcher.py", line 43, in dispatch
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb handler(*args, **kwargs)
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb File "/opt/stack/new/dragonflow/dragonflow/controller/l2_app.py", line 173, in remove_remote_port
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb match.set_metadata(network_id)
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb File "/usr/local/lib/python2.7/dist-packages/ryu/ofproto/ofproto_v1_3_parser.py", line 1299, in set_metadata
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb self.set_metadata_masked(metadata, UINT64_MAX)
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb File "/usr/local/lib/python2.7/dist-packages/ryu/ofproto/ofproto_v1_3_parser.py", line 1304, in set_metadata_masked
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb self._flow.metadata = metadata & mask
2016-03-23 09:52:17.703 10003 ERROR dragonflow.db.api_nb TypeError: unsupported operand type(s) for &: 'NoneType' and 'long'

[Li Ma (nick-ma-z)]

reduce the priority, because it only happened in fullstack.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/296916
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=daba82c66cb6ed183f9cafb120ae70d850e20dde
Submitter: Jenkins
Branch: master

commit daba82c66cb6ed183f9cafb120ae70d850e20dde
Author: Omer Anson <email address hidden>
Date: Thu Mar 24 08:46:50 2016 +0200

    Do not add lport to db_store via topology

    Adding an lport to db_store is already done in the df controller, via
    logical_port_updated. That method also ensures that unrelated ports
    (e.g. router_gateway) are not added. If they are forcefully added
    anyway, unexpected behaviour occurs, since they don't have e.g. chassis,
    and network_id, set.

    Change-Id: I4aec58e0f7c1aa839f6da535c1b4b8f46885cc16
    Closes-Bug: 1560923
    Related-Bug: 1561517