DOLFIN

Bug #891716
Comment #7

Comment 7 for bug 891716

Revision history for this message

Marie Rognes (meg-simula) wrote on 2011-11-17: Re: [Bug 891716] Re: Unit tests fail to run if Trilinos is installed but not PETSc

On 11/17/2011 10:53 PM, Andre Massing wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> On 11/17/2011 10:37 PM, Anders Logg wrote:
>> On Thu, Nov 17, 2011 at 10:24:56PM +0100, Andre Massing wrote: On
>> 11/17/2011 09:40 PM, Anders Logg wrote:
>>>>> Looks like the only remaining thing is periodic BC not
>>>>> working with Trilinos. From running the periodic demo:
>>>>>
>>>>> Error: Unable to add block of values to Epetra matrix. ***
>>>>> Reason: Did not manage to perform
>>>>> Epetra_FECrsMatrix::SumIntoGlobalValues. *** Where: This
>>>>> error was encountered inside EpetraMatrix.cpp.
>>>>>
>> I wrote a somewhat lengthy email about that, explaining what goes
>> wrong and asking for opinons... you have even replied to it :)
>>
>>> I know and I've read it carefully!
> I was just a bit confused about the implied desired action :)
>
>>> I think I responded and said that this needs to be addressed by
>>> incorporating boundary conditions into the FunctionSpace by
>>> implementing constrained spaces. I even linked to a blueprint.
> I have seen that, nice. Marie had already registered on at
> https://blueprints.launchpad.net/dolfin/+spec/constrained-spaces
> so these can be merged or the older one can be marked as superseded?

I think they both deserve to be kept. Although they are related, the one
does not necessarily imply the other.

I'll target the constrained-spaces one to 1.1 too.

--
Marie

>>> Bottom line: we won't fix this now so I'll add a check in that
>>> demo that it doesn't work with Epetra.
> Ok, I had the same feeling...But you could also use crisscross grids
> to fix it (just kidding ... )
>
> - --
> Andre
>
>
>>> -- Anders
>>
>> The bottom line is that there are several related issues: 1. The
>> sparsity pattern does not consider PeriodicBC thus there will be an
>> error in Trilinos when copying a slave row to a master row since
>> the matrix is filled / finalized.
>>
>> 2. Dirichlet and PeriodicBC calling and matrix.apply() while
>> applying bc. Every such call triggers a finalization of the matrix
>> atm.
>>
>> 3. https://bugs.launchpad.net/dolfin/+bug/891452 (which for some
>> reason does not show up in the bug overview, neither has been sent
>> to the list, strange.)
>>
>> See the original post
>> https://bugs.launchpad.net/dolfin/+bug/864741/comments/2
>>
>> for a more detailed explanation. The point is that it seems like a
>> more fundamental problem where I haven't dared to dirty-hack around
>> without opinions from the devs /maintainers :)
>>
>>
>>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.17 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQEcBAEBAgAGBQJOxYJAAAoJEA79ggnbq9dmTJkH/RrNfQpSUT3XOd7jy+sqsQtW
> AnXpoW9k8EfAk6UO9NpEAge7mt808EVZKR7PaTQw9G34twSunz63Fze08agIpLYY
> EWJx7mrubKuvl6DRkmJcsCh1FAeHw6mLHugnVizLyls3u5BVkrKB4KX9hLjI2vHM
> QaI4YKwt3VRUJb6uBujzUoDdR0MezhpHUyj2E4bsV//URuVmq8R2xBb+Hx2QALMx
> 1NtQ0yWUpPuh7lINlQBC+X7lwx8pd/LAje67ffpKR+g2ldskAzfoklF0cvOkQvsa
> loGhyC05WEs+jzfn+PMj3sJNoV4BIXJ4+AHwLVdhg9vXPY6C+T8ycWqvAqLuC58=
> =J8Fg
> -----END PGP SIGNATURE-----
>

On 11/17/2011 10:53 PM, Andre Massing wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> On 11/17/2011 10:37 PM, Anders Logg wrote:
>> On Thu, Nov 17, 2011 at 10:24:56PM +0100, Andre Massing wrote: On
>> 11/17/2011 09:40 PM, Anders Logg wrote:
>>>>> Looks like the only remaining thing is periodic BC not
>>>>> working with Trilinos. From running the periodic demo:
>>>>>
>>>>> Error:  Unable to add block of values to Epetra matrix. ***
>>>>> Reason: Did not manage to perform
>>>>> Epetra_FECrsMatrix::SumIntoGlobalValues. *** Where:  This
>>>>> error was encountered inside EpetraMatrix.cpp.
>>>>>
>> I wrote a somewhat lengthy email about that, explaining what goes
>> wrong and asking for opinons... you have even replied to it :)
>>
>>> I know and I've read it carefully!
> I was just a bit confused about the implied desired action :)
>
>>> I think I responded and said that this needs to be addressed by
>>> incorporating boundary conditions into the FunctionSpace by
>>> implementing constrained spaces. I even linked to a blueprint.
> I have seen that, nice. Marie had already registered on at
> https://blueprints.launchpad.net/dolfin/+spec/constrained-spaces
> so these can be merged or the older one can be marked as superseded?

I think they both deserve to be kept. Although they are related, the one 
does not necessarily imply the other.

I'll target the constrained-spaces one to 1.1 too.

--
Marie

>>> Bottom line: we won't fix this now so I'll add a check in that
>>> demo that it doesn't work with Epetra.
> Ok, I had the same feeling...But you could also use crisscross grids
> to fix it (just kidding ... )
>
> - --
> Andre
>
>
>>> -- Anders
>>
>> The bottom line is that there are several related issues: 1. The
>> sparsity pattern does not consider PeriodicBC thus there will be an
>> error in Trilinos when copying a slave row to a master row since
>> the matrix is filled / finalized.
>>
>> 2. Dirichlet and PeriodicBC calling and matrix.apply() while
>> applying bc. Every such call triggers a finalization of the matrix
>> atm.
>>
>> 3. https://bugs.launchpad.net/dolfin/+bug/891452 (which for some
>> reason does not show up in the  bug overview, neither has been sent
>> to the list, strange.)
>>
>> See the original post
>> https://bugs.launchpad.net/dolfin/+bug/864741/comments/2
>>
>> for a more detailed explanation. The point is that it seems like a
>> more fundamental problem where I haven't dared to dirty-hack around
>> without opinions from the devs /maintainers :)
>>
>>
>>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.17 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQEcBAEBAgAGBQJOxYJAAAoJEA79ggnbq9dmTJkH/RrNfQpSUT3XOd7jy+sqsQtW
> AnXpoW9k8EfAk6UO9NpEAge7mt808EVZKR7PaTQw9G34twSunz63Fze08agIpLYY
> EWJx7mrubKuvl6DRkmJcsCh1FAeHw6mLHugnVizLyls3u5BVkrKB4KX9hLjI2vHM
> QaI4YKwt3VRUJb6uBujzUoDdR0MezhpHUyj2E4bsV//URuVmq8R2xBb+Hx2QALMx
> 1NtQ0yWUpPuh7lINlQBC+X7lwx8pd/LAje67ffpKR+g2ldskAzfoklF0cvOkQvsa
> loGhyC05WEs+jzfn+PMj3sJNoV4BIXJ4+AHwLVdhg9vXPY6C+T8ycWqvAqLuC58=
> =J8Fg
> -----END PGP SIGNATURE-----
>