Rhythmbox Helper Not Showing Cover Art... Again

Reported by Chris Gross on 2010-05-10
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Docky
Low
Rico Tzschichholz

Bug Description

This bug was previously reported and supposedly fixed (https://bugs.launchpad.net/docky/+bug/519977), but it's back again. I've since upgraded to ubuntu 10.04/64 and I am not seeing album art in the rhythmbox helper. Last time, it seems that you guys found a way to have all album art automatically extracted to ~/.cache/rhythmbox/covers because for some reason, art embedded in the files could not be read (even though this works with the banshee helper).

Robert Dyer (psybers) on 2010-05-10
Changed in docky:
assignee: nobody → Rico Tzschichholz (ricotz)
importance: Undecided → Low
Rico Tzschichholz (ricotz) wrote :

Is it possible you are just missing the "python-mutagen" package?

Changed in docky:
status: New → Incomplete
Chris Gross (gross-cw) wrote :

actually, a cover appears when a track is played, but that particular album cover remains displayed indefinitely, even after the next track starts playing.

nam (nam85) wrote :

This is a bug in rhythmbox_control.py when you play two songs where the covers are extracted from the embedded tags. Then, the variable arturl in DockyRhythmboxItem::update_icon points to /tmp/docky_$USER_rhythmbox_helper.original.png. This file may get updated as the next song comes up, but the rhythmbox helper only check if the filenames differ (line 190).
I simply uncommented that if statement on my machine. I don't know if it would be more efficient to check the mtime of that file or get a hash.

But there's actually another thing I'd like to adress. rhythmbox_control.py looks for image files in the song folder first.
I have quite a few folders, where the cover image is called "Folder.jpg" (Windows Media Player did that), but rhythmbox_control.py looks for the lower-case variant and fails to detect the "Folder.jpg" file.

I added the other cases as well.

See attached patch.

Changed in docky:
status: Incomplete → Confirmed
Rico Tzschichholz (ricotz) wrote :

@nam: Thanks for the patch

Changed in docky:
status: Confirmed → Fix Committed
Chris Gross (gross-cw) wrote :

It works now. Thank you!

Changed in docky:
milestone: none → 2.0.4
Changed in docky:
status: Fix Committed → Fix Released

Accepted docky into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Rico Tzschichholz (ricotz) wrote :

Helpers are python-scripts running independently of docky and were fully synced with our trunk versions in this case.

The problem here was that embedded cover images of songs played in rhythmbox aren't updated correctly. Playing two songs with embedded images that are different revealed the problem. Therefore we added a check for the modification time of our temporary file to solve this case.

This fix was confirmed to work and therefore it is verified.
https://bugs.edge.launchpad.net/docky/+bug/578254/comments/5

tags: added: verification-done
removed: verification-needed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers