Comment 3 for bug 578254

Revision history for this message
nam (nam85) wrote :

This is a bug in rhythmbox_control.py when you play two songs where the covers are extracted from the embedded tags. Then, the variable arturl in DockyRhythmboxItem::update_icon points to /tmp/docky_$USER_rhythmbox_helper.original.png. This file may get updated as the next song comes up, but the rhythmbox helper only check if the filenames differ (line 190).
I simply uncommented that if statement on my machine. I don't know if it would be more efficient to check the mtime of that file or get a hash.

But there's actually another thing I'd like to adress. rhythmbox_control.py looks for image files in the song folder first.
I have quite a few folders, where the cover image is called "Folder.jpg" (Windows Media Player did that), but rhythmbox_control.py looks for the lower-case variant and fails to detect the "Folder.jpg" file.

I added the other cases as well.

See attached patch.