Comment 11 for bug 248743

Revision history for this message
In , Tlillqvist (tlillqvist) wrote :

There isn't really much more that can be done in OOo for this. Locking on opening a file though gnome-vfs requires support for it to exist in gnome-vfs. That support exists only in SUSE's gnome-vfs (and other distros that might have borrowed the same patch). (And even in that, such locking on opening is implemented only for smb. In theory it could be implemented for local files also on BSD and MacOSX as far as I know. It would have been nice if the SUSE patch had also provided an API to check whether the lock-on-open request can be handled for a particular URI (or after the open, whether it was actually handled or not).)

What we probably should do in ooo-build is remove this part of gnome-vfs-locking-ucb.diff:

+.IF "$(GNOMEVFS_HAS_LOCKING)" != "YES"
+CFLAGS+=-DGNOME_VFS_OPEN_LOCKED=16
+.ENDIF
+

i.e. thus not having OOo think that the gnome-vfs it is being built against has GNOME_VFS_OPEN_LOCKED even if it doesn't. Instead add to the patch ifdefs on GNOME_VFS_OPEN_LOCKED around the code that tries to use it.

Kendy and Chris, what do you think of that?

Maybe also add a big warning to gnome-vfs-locking-config_office.diff that says "Your gnome-vfs does not implement GNOME_VFS_OPEN_LOCKED. Be afraid"