devstack

  1. Bug #2009521
  2. Comment #2

Comment 2 for bug 2009521

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.opendev.org/c/openstack/devstack/+/876601
Committed: https://opendev.org/openstack/devstack/commit/f834f9adaf9c228ff4ec6a5e24e6d4cf3ca6a992
Submitter: "Zuul (22348)"
Branch: master

commit f834f9adaf9c228ff4ec6a5e24e6d4cf3ca6a992
Author: Michael Johnson <email address hidden>
Date: Mon Mar 6 18:47:03 2023 +0000

    Fix NotImplementedError in dbcounter on SQLA 2.x

    This patch fixes a NotImplementedError raised in the dbcounter plugin when using SQLAlchemy 2.x. The plugin signature has changed and now requires an "update_url" method as part of the plugin[1].
    This patch also updates the do_incr() explicit SQL string to use a TextClause and the new requirement for named bound parameters[2].

    Closes-Bug: #2009521

    [1] https://docs.sqlalchemy.org/en/20/changelog/migration_14.html#changes-to-createengineplugin
    [2] https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#execute-method-more-strict-execution-options-are-more-prominent

    Change-Id: Ie5484597057a3306757cc46b657446ad61ac2098