devstack

Bug #1883468
Comment #10

Comment 10 for bug 1883468

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-06-17: Related fix merged to devstack (stable/train)

#10

Reviewed: https://review.opendev.org/735536
Committed: https://git.openstack.org/cgit/openstack/devstack/commit/?id=20e04092c8ce311017b2d490c4041cfb9b3a9395
Submitter: Zuul
Branch: stable/train

commit 20e04092c8ce311017b2d490c4041cfb9b3a9395
Author: Ian Wienand <email address hidden>
Date: Thu May 3 10:51:30 2018 +1000

Fix gate issues

This is a combination of 3 commits.
This is the 1st commit message:

Work around uwsgi breakage

    uwsgi broke installation from source with their latest release [0].
    Since we want to move away from source installation anyway, make
    grenade based jobs non-voting for the moment so that we can backport
    [1] properly.

[0] https://bugs.launchpad.net/bugs/1883468
[1] https://review.opendev.org/577955

This is the commit message #2:

Use packaged uwsgi on Fedora and Ubuntu

    Building uwsgi from source was a workaround that was introduced a long
    time ago, it doesn't seem like it is needed anymore and will actually
    fail for Ubuntu 20.04.

    Also it doesn't match what will happen for most real-world
    installations, so let's try to get back to using distro packages. We'll
    still use the source install for RHEL/Centos, it remains to be tested
    whether we can get back to using distro versions there, too.

This is the commit message #3:

Use uwsgi binary from path

    All these uwsgi invocations assume that the uwsgi binary is in the
    same directory as their project binaries are installed into (probably
    /usr/bin). That may not be correct -- for example if using a packaged
    uwsgi on Fedora the binary will live in /usr/sbin/uwsgi (not /usr/bin
    where the project files from pip are).

Switch invocations to just find it in the path.

While all this was happening, Zuul updated to Ansible 2.9 as well, so
we require a fix for Ansible syntax in 736006 as well.

    Depends-On: https://review.opendev.org/735535
    Depends-On: https://review.opendev.org/736006
    Related-Bug: 1883468

    Change-Id: I82f539bfa533349293dd5a8ce309c9cc0ffb0393
    (cherry picked from commit 84737ebd96327310ec5f8f7c312aeae12cbeb234)
    (cherry picked from commit 2d903568ed4158aa668bbda6986307a8780c71a4)
    (cherry picked from commit 312517d5101206b33d3c395d27ec93d385b7fd24)

Reviewed:  https://review.opendev.org/735536
Committed: https://git.openstack.org/cgit/openstack/devstack/commit/?id=20e04092c8ce311017b2d490c4041cfb9b3a9395
Submitter: Zuul
Branch:    stable/train

commit 20e04092c8ce311017b2d490c4041cfb9b3a9395
Author: Ian Wienand <iwienand@redhat.com>
Date:   Thu May 3 10:51:30 2018 +1000

Fix gate issues
    
    This is a combination of 3 commits.
    This is the 1st commit message:
    
    Work around uwsgi breakage
    
    uwsgi broke installation from source with their latest release [0].
    Since we want to move away from source installation anyway, make
    grenade based jobs non-voting for the moment so that we can backport
    [1] properly.
    
    [0] https://bugs.launchpad.net/bugs/1883468
    [1] https://review.opendev.org/577955
    
    This is the commit message #2:
    
    Use packaged uwsgi on Fedora and Ubuntu
    
    Building uwsgi from source was a workaround that was introduced a long
    time ago, it doesn't seem like it is needed anymore and will actually
    fail for Ubuntu 20.04.
    
    Also it doesn't match what will happen for most real-world
    installations, so let's try to get back to using distro packages. We'll
    still use the source install for RHEL/Centos, it remains to be tested
    whether we can get back to using distro versions there, too.
    
    This is the commit message #3:
    
    Use uwsgi binary from path
    
    All these uwsgi invocations assume that the uwsgi binary is in the
    same directory as their project binaries are installed into (probably
    /usr/bin).  That may not be correct -- for example if using a packaged
    uwsgi on Fedora the binary will live in /usr/sbin/uwsgi (not /usr/bin
    where the project files from pip are).
    
    Switch invocations to just find it in the path.
    
    While all this was happening, Zuul updated to Ansible 2.9 as well, so
    we require a fix for Ansible syntax in 736006 as well.
    
    Depends-On: https://review.opendev.org/735535
    Depends-On: https://review.opendev.org/736006
    Related-Bug: 1883468
    
    Change-Id: I82f539bfa533349293dd5a8ce309c9cc0ffb0393
    (cherry picked from commit 84737ebd96327310ec5f8f7c312aeae12cbeb234)
    (cherry picked from commit 2d903568ed4158aa668bbda6986307a8780c71a4)
    (cherry picked from commit 312517d5101206b33d3c395d27ec93d385b7fd24)