Comment 7 for bug 1474035

Revision history for this message
Michi Henning (michihenning) wrote :

Thanks for that David! I spotted a few minor errors and omissions. Could you look at these please?

In "How to use it":

image://thumbnailer/<file path>"

should be

image://thumbnailer/<file URI>

Also, on the same line, the comment "local videos and pictures" really should be "local videos, audio files, or pictures"

image://albumart/album=Blur:+The+Best+Of&artist=Blur"

It looks like the "+" signs should be "%20"? (This also appears in the URI after this one.)

The "Cosmos Laundromat" and "Cry Me A River" URIs should have %20 instead of spaces.

It might be nice to add an example that same box that shows how to extract a thumbnail from an image file (just to make it clear that this can be done too).

It would be good to mention the media.getArtUri() method, which creates a thumbnailer URI. Otherwise, people are likely to cobble the URIs together by hand and get it wrong half the time...

I think the page needs some explanation of semantics. Specifically:

The thumbnailer always preserves aspect ratio.

Returned thumbnails may be smaller than what was asked for because the thumbnailer never up-scales. If the original artwork is smaller than what was asked for, the largest possible thumbnail will be returned. Thumbnails are never larger than 1920 pixels in the larger dimension (even if the original artwork is larger).

Requests with either dimension < 0 are invalid and return an error.

Requests for (0,0) mean "as large as possible" (subject to the 1920 pixel limit).

Requests for (x,0) or (0,y) mean the same as (x,x) and (y,y), respectively.