Calls git log when building docs

Bug #1552251 reported by Thomas Goirand
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Low
Unassigned
Designate
Medium
pawnesh kumar
OpenStack Shared File Systems Service (Manila)
Undecided
Unassigned
glance_store
Low
Thomas Bechtold
oslo.config
Undecided
Davanum Srinivas (DIMS)
oslo.messaging
Undecided
Davanum Srinivas (DIMS)
osprofiler
Undecided
Davanum Srinivas (DIMS)
python-mistralclient
Undecided
Corey Bryant
taskflow
Undecided
Davanum Srinivas (DIMS)
zaqar
Undecided
pawnesh kumar

Bug Description

When building oslo.messaging Debian package 4.5.0, I get:

sphinx-build -D html_last_updated_fmt="March 02, 2016" -b html doc/source /home/zigo/sources/openstack/mitaka/python-oslo.messaging/build-area/python-oslo.messaging-4.5.0/debian/python-oslo.messaging/usr/share/doc/python-oslo.messaging/html
Running Sphinx v1.3.5
making output directory...
fatal: Not a git repository (or any of the parent directories): .git

Exception occurred:
  File "/usr/lib/python2.7/subprocess.py", line 574, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '['git', 'log', "--pretty=format:'%ad, commit %h'", '--date=local', '-n1']' returned non-zero exit status 128

Obviously, what's in doc/source/conf.py is wrong:

git_cmd = ["git", "log", "--pretty=format:'%ad, commit %h'", "--date=local",
           "-n1"]
html_last_updated_fmt = subprocess.check_output(git_cmd,
                                                stdin=subprocess.PIPE)

Please get this removed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/287447

Changed in oslo.messaging:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: New → In Progress
Changed in oslo.config:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/287448

Changed in osprofiler:
status: New → In Progress
Changed in taskflow:
status: New → In Progress
Changed in osprofiler:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
Changed in taskflow:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to taskflow (master)

Reviewed: https://review.openstack.org/287452
Committed: https://git.openstack.org/cgit/openstack/taskflow/commit/?id=a2d4731f9a291efc0f96694618711aaa9f763070
Submitter: Jenkins
Branch: master

commit a2d4731f9a291efc0f96694618711aaa9f763070
Author: Davanum Srinivas <email address hidden>
Date: Wed Mar 2 16:29:05 2016 -0500

    Fallback if git is absent

    When building packages if git is absent, then we should
    fall back to a safe default.

    Closes-Bug: #1552251
    Change-Id: Ife309625a380cf7d5cc42581ed6d8f9f72b86cd9

Changed in taskflow:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to osprofiler (master)

Reviewed: https://review.openstack.org/287451
Committed: https://git.openstack.org/cgit/openstack/osprofiler/commit/?id=5f8d6def01119f836771f04293b07c31df239184
Submitter: Jenkins
Branch: master

commit 5f8d6def01119f836771f04293b07c31df239184
Author: Davanum Srinivas <email address hidden>
Date: Wed Mar 2 16:28:43 2016 -0500

    Fallback if git is absent

    When building packages if git is absent, then we should
    fall back to a safe default.

    Closes-Bug: #1552251
    Change-Id: I9b21700f942f5d1f9302b3af04d6d24e1afba1b3

Changed in osprofiler:
status: In Progress → Fix Released
Changed in oslo.messaging:
status: In Progress → Fix Committed
Changed in oslo.config:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/287447
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=4e4caf67da4775167c941671a6ea694d6d409b88
Submitter: Jenkins
Branch: master

commit 4e4caf67da4775167c941671a6ea694d6d409b88
Author: Davanum Srinivas <email address hidden>
Date: Wed Mar 2 16:23:18 2016 -0500

    Fallback if git is absent

    When building packages if git is absent, then we should
    fall back to a safe default.

    Closes-Bug: #1552251
    Change-Id: I9731416117de088282259846d49c2ec3ce09d1dc

Changed in oslo.messaging:
status: Fix Committed → Fix Released
Changed in oslo.config:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.config (master)

Reviewed: https://review.openstack.org/287448
Committed: https://git.openstack.org/cgit/openstack/oslo.config/commit/?id=a1a1c89c0d2963e4496cc8e7c0f1e6d0aa3a3104
Submitter: Jenkins
Branch: master

commit a1a1c89c0d2963e4496cc8e7c0f1e6d0aa3a3104
Author: Davanum Srinivas <email address hidden>
Date: Wed Mar 2 16:27:47 2016 -0500

    Fallback if git is absent

    When building packages if git is absent, then we should
    fall back to a safe default.

    Closes-Bug: #1552251
    Change-Id: I5201b8537b76ff731600720c8310ad4a2b9256e0

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to oslo.config (master)

Reviewed: https://review.openstack.org/290255
Committed: https://git.openstack.org/cgit/openstack/oslo.config/commit/?id=0d10f6b1fec261cddcfb37dfbd6bc4b9902f5c67
Submitter: Jenkins
Branch: master

commit 0d10f6b1fec261cddcfb37dfbd6bc4b9902f5c67
Author: ChangBo Guo(gcb) <email address hidden>
Date: Wed Mar 9 11:21:04 2016 +0800

    doc:Log warning when can't get information from git

    This is follow up of commit a1a1c89c0d2963e4496cc8e7c0f1e6d0aa3a3104,
    add warning to indicate something is wrong when getting last updated
    information from git repository.

    Related-Bug: #1552251
    Change-Id: I1ba2d4fe1fb3909742bd1a2f552e917effb35faa

Eric Harney (eharney)
Changed in cinder:
importance: Undecided → Low
status: New → In Progress
Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/305001
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e7f55be9a9538fda7a75bb3c71d4e9341368633f
Submitter: Jenkins
Branch: master

commit e7f55be9a9538fda7a75bb3c71d4e9341368633f
Author: Thomas Bechtold <email address hidden>
Date: Wed Apr 13 09:18:02 2016 +0200

    Fix doc build if git is absent

    When building packages if git is absent, then we should not set
    html_last_updated_fmt. It can still be set via the -D switch
    when building with sphinx-build.

    Change-Id: Ib289335198b0fe0a00922cbfe5c7fd7ff438ffcf
    Closes-Bug: #1552251

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/keystoneauth 2.6.0

This issue was fixed in the openstack/keystoneauth 2.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/304994
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=fd9b5c04353e79f9bf006de3d8fca90730af2511
Submitter: Jenkins
Branch: master

commit fd9b5c04353e79f9bf006de3d8fca90730af2511
Author: Thomas Bechtold <email address hidden>
Date: Wed Apr 13 09:00:12 2016 +0200

    Fix doc build if git is absent

    When building packages if git is absent, then we should not set
    html_last_updated_fmt. It can still be set via the -D switch
    when building with sphinx-build.

    Change-Id: I02a6bcb43c8283848fb3866bb52cc4c0f50f4c92
    Closes-Bug: #1552251

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/osprofiler 1.3.0

This issue was fixed in the openstack/osprofiler 1.3.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/oslo.messaging 5.0.0

This issue was fixed in the openstack/oslo.messaging 5.0.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/taskflow 1.31.0

This issue was fixed in the openstack/taskflow 1.31.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystonemiddleware 4.5.0

This issue was fixed in the openstack/keystonemiddleware 4.5.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/oslo.config 3.10.0

This issue was fixed in the openstack/oslo.config 3.10.0 release.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/glance 13.0.0.0b1

This issue was fixed in the openstack/glance 13.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/sahara 5.0.0.0b1

This issue was fixed in the openstack/sahara 5.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 9.0.0.0b1

This issue was fixed in the openstack/cinder 9.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystone 10.0.0.0b1

This issue was fixed in the openstack/keystone 10.0.0.0b1 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/heat 7.0.0.0b1

This issue was fixed in the openstack/heat 7.0.0.0b1 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/nova 14.0.0.0b1

This issue was fixed in the openstack/nova 14.0.0.0b1 development milestone.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/manila 3.0.0.0b1

This issue was fixed in the openstack/manila 3.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b1

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron-fwaas 9.0.0.0b1

This issue was fixed in the openstack/neutron-fwaas 9.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron-vpnaas 9.0.0.0b1

This issue was fixed in the openstack/neutron-vpnaas 9.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/swift 2.8.0

This issue was fixed in the openstack/swift 2.8.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/osprofiler 1.3.0

This issue was fixed in the openstack/osprofiler 1.3.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron-lbaas 9.0.0.0b2

This issue was fixed in the openstack/neutron-lbaas 9.0.0.0b2 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/aodh 3.0.0.0b2

This issue was fixed in the openstack/aodh 3.0.0.0b2 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/ceilometer 7.0.0.0b2

This issue was fixed in the openstack/ceilometer 7.0.0.0b2 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/aodh 3.0.0.0b2

This issue was fixed in the openstack/aodh 3.0.0.0b2 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/ceilometer 7.0.0.0b2

This issue was fixed in the openstack/ceilometer 7.0.0.0b2 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/python-heatclient 1.4.0

This issue was fixed in the openstack/python-heatclient 1.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-zaqarclient 1.2.0

This issue was fixed in the openstack/python-zaqarclient 1.2.0 release.

Revision history for this message
Nikhil Komawar (nikhil-komawar) wrote :
Changed in glance-store:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Thomas Bechtold (toabctl)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance_store (master)

Reviewed: https://review.openstack.org/364532
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=34c0108a8aa24cb686433ec8bf9208830faa97f4
Submitter: Jenkins
Branch: master

commit 34c0108a8aa24cb686433ec8bf9208830faa97f4
Author: Thomas Bechtold <email address hidden>
Date: Thu Sep 1 21:55:56 2016 +0200

    Fix doc build if git is absent

    When building packages if git is absent, then we should not set
    html_last_updated_fmt. It can still be set via the -D switch
    when building with sphinx-build.

    Change-Id: Ia63ebf075edeb3aec03c7968efc8ae452a94696b
    Closes-Bug: #1552251

Changed in glance-store:
status: In Progress → Fix Released
Changed in zaqar:
assignee: nobody → pawnesh kumar (pawnesh.kumar)
Changed in designate:
assignee: nobody → pawnesh kumar (pawnesh.kumar)
wangxiyuan (wangxiyuan)
Changed in zaqar:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.openstack.org/382735
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=f3b4745398e16f7a25b0f83df88196f5b13181f3
Submitter: Jenkins
Branch: master

commit f3b4745398e16f7a25b0f83df88196f5b13181f3
Author: pawnesh.kumar <email address hidden>
Date: Thu Oct 6 11:42:58 2016 +0530

    Fix doc build if git is absent

    When building packages if git is absent, then we should not set
    html_last_updated_fmt. It can still be set via the -D switch
    when building with sphinx-build.

    Change-Id: I48c6fb8bc25f651626d2751923f6a15b9939784c
    Closes-Bug: #1552251

Changed in zaqar:
status: In Progress → Fix Released
Tim Simmons (timsim)
Changed in designate:
status: New → Triaged
importance: Undecided → Medium
Changed in ironic:
assignee: nobody → pawnesh kumar (pawnesh.kumar)
Changed in ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-saharaclient 1.0.0

This issue was fixed in the openstack/python-saharaclient 1.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-zaqarclient 1.2.0

This issue was fixed in the openstack/python-zaqarclient 1.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-saharaclient 1.0.0

This issue was fixed in the openstack/python-saharaclient 1.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/zaqar 4.0.0.0b1

This issue was fixed in the openstack/zaqar 4.0.0.0b1 development milestone.

Revision history for this message
Jay Faulkner (jason-oldos) wrote :

Pawnesh, if you're not intending on posting a patch for this to Ironic, please unassign yourself from the bug. Thanks!

Changed in ironic:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-senlinclient 1.1.0

This issue was fixed in the openstack/python-senlinclient 1.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-zaqarclient 1.2.0

This issue was fixed in the openstack/python-zaqarclient 1.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance_store 0.19.0

This issue was fixed in the openstack/glance_store 0.19.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-lib 1.1.0

This issue was fixed in the openstack/neutron-lib 1.1.0 release.

Changed in mistral:
assignee: nobody → Corey Bryant (corey.bryant)
no longer affects: mistral
Changed in python-mistralclient:
assignee: nobody → Corey Bryant (corey.bryant)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 4.0.0.0rc2

This issue was fixed in the openstack/mistral 4.0.0.0rc2 release candidate.

Revision history for this message
Anastasia Kuznetsova (akuznetsova) wrote :

Bug was fixed in python-mistralcleint in https://review.openstack.org/#/c/422784/

Changed in python-mistralclient:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 5.0.0.0b1

This issue was fixed in the openstack/mistral 5.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-mistralclient 3.1.0

This issue was fixed in the openstack/python-mistralclient 3.1.0 release.

Revision history for this message
Vladyslav Drok (vdrok) wrote :

Pretty old bug, and I don't see any git calls in ironic's doc/source/conf.py

no longer affects: ironic
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-mistralclient 3.0.1

This issue was fixed in the openstack/python-mistralclient 3.0.1 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers