Comment 10 for bug 407672

@linuxfood: Thank you for your work. I'm trying it out right now in the test shell. It looks good to me. I can't review the code very thoroughly though, as I don't know Déjà-Dup's codebase enough.

The periodic-period-length key that you added is in plural form ("days"), which sounds a bit weird to me ("how many days in a period length?", I was wondering). Maybe consider using something more precise, like "1d"/"1h"/"7d" or "24"/"1"/"168" perhaps? Or just the singular form?

Wouldn't the implementation have been easier if you had changed the unit of periodic-period from day to hour, instead of introducing an additional key? (I'm not sure.) So the previous default periodic-period=1 would have become periodic-period=24. Or if you had allowed a decimal value, e.g. periodic-period=0.25 for six hours?

I'm thinking the "Next backup is overdue!" message is going to make non-experienced users anxious. They're going to worry about Déjà-Dup not properly backing up their data. The current "today" tells them a backup is going to be attempted soon.

I found a small bug too: in deja-dup-preferences, when changing the period length to something with a smaller range (e.g. from Days: 1 2 3 4 5 6 7 to Weeks: 1 2 3 4), the selected period is not changed to fit the new range, which makes it possible to select a combination you probably didn't mean to allow (e.g. 7 Weeks). See attached picture. The resulting periodic-period and periodic-period-length keys are correctly set (in this case to "7" and "weeks").

Thanks again!