Comment 7 for bug 1549776

Revision history for this message
Naël (nathanael-naeri) wrote :

Thanks Vej, I think your patch fixes this bug: it's fine if Déjà-Dup doesn't support this feature, as long as it's documented. We can follow-up with a wishlist bug if necessary.

That said, I've looked into what may be needed to support this particular feature, and it seems to me it's a fairly trivial alteration of the function parse_keywords in the file DirHandling.vala.

I'm including the following patch (my first one!), can you please review it? If you think it's fine I'll publish it in a branch (also my first one!). Please note that I know very little of both Vala and Déjà-Dup's code.

This patch compiles and passes all the included tests (make check), several of which include $HOME, $TRASH, $DOWNLOADS in include and exclude lists, so at least it should not introduce obvious regressions.

I'll test it more extensively as soon as I can find out how without messing up my own backups and backup settings.