Comment 118 for bug 644898

Revision history for this message
Cefn (6-launchpad-net-cefn-com) wrote :

I've just attempted to use the 'raring' version of the toshiba-acpi-fix package from https://launchpad.net/~keks9n/+archive/main

I was impressed to find that against one of the kernels in my Ubuntu Gnome Saucy (13.10) the kernel 3.9.0-7 the patched toshiba_acpi does indeed build and function, and although the hardware button doesn't work, I can turn on transflective mode from the command line with...
sudo toshset -trmode on
and back off with...
sudo toshset -trmode off

Sadly, with either of the 3.11 kernels (also installed) the build fails, and below is a typical error from the build process...

Building toshiba_acpi for 3.11.0-2-generic
make -C /lib/modules/3.11.0-2-generic/build M=/tmp/tmp.jtXi5Oxy3w modules
make[1]: Entering directory `/usr/src/linux-headers-3.11.0-2-generic'
  CC [M] /tmp/tmp.jtXi5Oxy3w/toshiba_acpi.o
/tmp/tmp.jtXi5Oxy3w/toshiba_acpi.c: In function ‘version_proc_open’:
/tmp/tmp.jtXi5Oxy3w/toshiba_acpi.c:827:2: error: implicit declaration of function ‘PDE’ [-Werror=implicit-function-declaration]
  return single_open(file, version_proc_show, PDE(inode)->data);
  ^
/tmp/tmp.jtXi5Oxy3w/toshiba_acpi.c:827:56: error: invalid type argument of ‘->’ (have ‘int’)
  return single_open(file, version_proc_show, PDE(inode)->data);
                                                        ^
/tmp/tmp.jtXi5Oxy3w/toshiba_acpi.c:828:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
cc1: some warnings being treated as errors
make[2]: *** [/tmp/tmp.jtXi5Oxy3w/toshiba_acpi.o] Error 1
make[1]: *** [_module_/tmp/tmp.jtXi5Oxy3w] Error 2
make[1]: Leaving directory `/usr/src/linux-headers-3.11.0-2-generic'
make: *** [all] Error 2
cp toshiba_acpi.ko /lib/modules/3.11.0-2-generic/kernel/drivers/platform/x86/toshiba_acpi.ko
cp: cannot stat ‘toshiba_acpi.ko’: No such file or directory
make: *** [install] Error 1