crop to selection is totally off (FFe update Pinta to 1.6)

Bug #1305701 reported by Rolf Leggewie
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Pinta
Fix Released
Undecided
Cameron White
pinta (Debian)
Fix Released
Unknown
pinta (Ubuntu)
Fix Released
Medium
Unassigned
Trusty
Fix Released
Undecided
Unassigned

Bug Description

I'd like to upload Pinta 1.6 to Ubuntu.

I've packaged it and it b/i/r. Will probably do this via experimental as a sync. Our 1.3 package is badly lagging upstream and has a few bugs that are fixed now (see this report for one example). It's a leaf package.

Here's the upstream NEWS

Pinta 1.6

New Features / Improvements:

    Redesigned shape tools (demo video):
        The Line tool now supports drawing curves and arrows
        Shapes remain editable after being drawn
        All shape tools now support drawing dashed lines
    All selection tools now support the Union, Exclude, Xor, and Intersection modes
    New community add-in repository - add-ins can be installed through the Add-in Manager dialog (via the Add-ins menu)
    Redesigned New Image dialog, which includes presets, orientation and background options, and a thumbnail preview of the image.
    The toolbox and color palette now have a flexible layout and can expand horizontally, making them significantly more usable on small screens.
    When launching Pinta from the command line, the standard --version and --help options are now supported.

Bug Fixes:

A full list of bug fixes is available at https://launchpad.net/pinta/+milestone/1.6.

    Fixed a number of issues with the text tool’s support for Unicode text (#1361560)
    Fixed a number of issues with undoing selections (#1419083, #990350)
    Fixed a number of untranslatable strings throughout Pinta, and the zoom toolbar’s percentages are now formatted using the current locale.
    The text tool now supports the standard shortcuts for toggling bold (Ctrl+B), italic (Ctrl+I), and underline (Ctrl+U), and all of the text can be selected with Ctrl+A.
    Fixed a potential crash after undoing a text action (#1206003)
    Fixed a crash when holding both the left and right mouse buttons with the Pencil tool (#1317284)
    Fixed issues with zooming in very far on large images
    Fixed a potential crash when exiting Pinta (#1171200, #1331893 and #1075472)
    Fixed issues with the toolbar’s state (hidden vs. visible) not being preserved after re-opening Pinta (#1412264)
    Fixed several bugs where undo did not work correctly for the Freeform Shape tool (#1210927, #1422265)
    Fixed a bug where resizing a selection allowed the selection to grow beyond the edge of the canvas (#1195062)
    The selection handles are now larger and easier to click (#1268333)
    Fixed bugs where using the Recolor tool after the Line/Curve tool resulted in odd behavior (#1422710, #1422715)
    The error dialog now includes a link to the bug tracker (#1191357)
    Improved the error message when opening an unsupported file format (#1188993)
    Fixed an issue where cancelling the saving of a jpg image made it appear that the image had actually been saved (#1322878)
    Auto-hiding now works correctly for the history and open images pads (#1358664)
    Auto Crop now works correctly if there is an active selection (#1194859)
    The progress dialog is now modal (#1192926)
    The Backspace and Delete keys are now usable when editing text fields in the toolbar (#1335442)
    Improved the readability of the text cursor against dark backgrounds (#1190862)

Pinta 1.5

New Features / Improvements:

    Re-editable text
    Mouse cursors now resize based on the active brush size.
    The Move Selection and Move Selected tools can now rotate the selection using the right mouse button.
    Added an Invert Selection command.
    New or redesigned mouse cursors for every tool.
    Improved OSX integration (file associations and improved dock integration)
    Redesigned Windows installer, which automatically downloads and installs the correct version of GTK# and the .NET Framework if necessary
    Improved JPEG Compression Dialog (remembers previous settings and has the OK button as the default control)
    The Open File dialog now shows image previews for ORA files, as well as any file formats provided by add-ins.

Add-in Support:

Pinta now supports add-ins that can provide additional effects, tools, brushes, and file formats.

    Users can use the Add-in Manager (under the Add-ins menu) to browse and install add-ins.
    We are in the process of setting up a community add-in repository which will be included by default in future Pinta releases.
    Developers can visit https://github.com/PintaProject/Pinta/wiki to learn more about developing their own add-ins.

Bug Fixes:

A full list of bug fixes is available at https://launchpad.net/pinta/+milestone/1.5.

    Fixed a bug with saving to filenames with non-English characters on Windows.
    Fixed a crash when the Pixel Grid was turned on for very small images
    Fixed a bug on Windows where the clipboard would sometimes paste old images.
    Fixed a bug in the Freeform Shape tool that caused it to function incorrectly when running on newer versions of GTK#.
    Fixed a bug in the text tool that caused font variants (e.g. Segoe Black and Segoe Condensed) to not work correctly.
    Fixed a bug that caused the Rectangle Select markers to still be visible after undoing a selection.
    Fixed several dialogs that did not have correct parent windows
    Fixed a bug with using non-English fonts in the text tool on Windows
    Fixed a bug that caused part of the image to be lost when pasting a large image onto a smaller canvas
    Fixed a bug in the Gradient tool that caused an empty 1-pixel line to appear at the top of the image.
    Fixed a bug where using the Backspace key in the text tool while inside a selection would fill the selection instead of deleting a character.
    Fixed a bug where the canvas would be redrawn slightly incorrectly when zoomed in or out.
    Fixed a bug where a pasted image would be pasted at the top left of the image instead of the top left of the window when zoomed in
    Fixed conflicting shortcuts for the Brightness and Contrast tool and the Copy Merged command
    Fixed a bug where some icons would not display correctly with GTK# 2.12.20
    Fixed a crash when pasting into a new image with an empty clipboard
    Fixed a crash when leaving the Move Selection tool with no open documents.
    Fixed several bugs with drawing off-canvas with the Paintbrush and Pencil tools
    The About dialog now uses the system default font instead of a hardcoded font.
    If no images are open, Ctrl+V now pastes into a new image.
    Fixed issues with the Magic Wand cursor's hotspot being incorrect
    Fixed a bug with the Clone Stamp tool's cursor after changing the brush width
    The percentage fields in the Resize Canvas/Image dialogs now get focus and selection when the dialog is opened.
    The order of the buttons in the Save dialog now match the standard Windows order when running Pinta on Windows
    The layer preview is now updated correctly after pasting an image
    Fixed bugs with being unable to open certain PNG files on Windows.
    Pinta can now be quit from the OSX dock
    Pinta can now be correctly restored by left clicking on the dock icon after minimizing it on OSX
    Files can now be opened by dropping them on Pinta's dock icon.
    Closed images are now properly removed from the Window menu on OSX.
    Pinta now has correct file associations for OSX and can be used to open images from Finder.
    Fixed several bug when running Pinta with newer versions of Mono.Cairo (such as on Ubuntu 14.04).

[ Original report / SRU information ]

Marking a region in a picture and then choosing "Image - Crop to Selection" is not working as expected. The resulting picture is not really the previously selected region.

Revision history for this message
Cameron White (cameronwhite91) wrote :

I'm seeing this as well after installing 14.04.

Changed in pinta (Ubuntu):
status: New → Confirmed
Changed in pinta:
status: New → Fix Committed
Changed in pinta (Ubuntu):
status: Confirmed → Triaged
Revision history for this message
Cameron White (cameronwhite91) wrote :
Changed in pinta:
assignee: nobody → Cameron White (cameronwhite91)
milestone: none → 1.5
Changed in pinta:
status: Fix Committed → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

Cameron, thank you for that patch. Unfortunately, it seems to have a lot of unrelated changes lumped in and thus will not make it into Trusty, I'm afraid. Can you work up a minimal patch to fix this issue and this issue alone?

Revision history for this message
Cameron White (cameronwhite91) wrote :

There are a bunch of workarounds in that merge commit for compiling on older Ubuntu versions, but https://github.com/PintaProject/Pinta/commit/636e3545ddced50a6ff362b359b8336309585ed7 should do it for Trusty, I think.

Revision history for this message
Rolf Leggewie (r0lf) wrote :

Cameron, thank you for your work.

Fro the changes you made to this ticket I guess that the fix was committed to the 1.5 branch upstream? In other words, we will now need to fix utopic as well (or the v-series when it opens)

Changed in pinta (Debian):
status: Unknown → Confirmed
Revision history for this message
Rolf Leggewie (r0lf) wrote :

hunk 2 and 3 of that patch do not apply to the 1.3 sources in trusty and utopic

Can you rebase?

Revision history for this message
Rolf Leggewie (r0lf) wrote :

ping Cameron

Revision history for this message
Cameron White (cameronwhite91) wrote :

I've attached a patch made against Pinta's release-1.3 branch that should work.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "fix_crop_to_selection.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Rolf Leggewie (r0lf) wrote :

successfully compiled the proposed patch and verified the fix in trusty

Revision history for this message
Rolf Leggewie (r0lf) wrote :
Revision history for this message
Iain Lane (laney) wrote :

I'll upload to trusty. Rolf, can you please update the bug description with the required SRU information? https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

For Vivid, I think we should try to go for 1.6 first. Let me see if we can get a freeze breka.

Changed in pinta (Ubuntu):
status: Triaged → New
description: updated
summary: - crop to selection is totally off
+ crop to selection is totally off (FFe update Pinta to 1.6)
Changed in pinta (Ubuntu Trusty):
status: New → In Progress
Revision history for this message
Iain Lane (laney) wrote : Re: [Bug 1305701] [NEW] crop to selection is totally off (FFe update Pinta to 1.6)

On Mon, Mar 02, 2015 at 06:00:18PM -0000, Launchpad Bug Tracker wrote:
> You have been subscribed to a public bug by Iain Lane (laney):
>
> I'd like to upload Pinta 1.6 to Ubuntu.

ping release team

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Rolf Leggewie (r0lf) wrote :

On 09.03.2015 18:08, Iain Lane wrote:
> ping release team

ping Ian re trusty upload ;-)

Revision history for this message
Iain Lane (laney) wrote :

You need to put the SRU information in first, please.

Revision history for this message
Scott Kitterman (kitterman) wrote :

Ack. Approved. Please go ahead (for vivid).

Changed in pinta (Ubuntu):
status: New → Triaged
Revision history for this message
Brian Murray (brian-murray) wrote :

The SRU information (at the bottom of the bug description) is missing a test case.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pinta - 1.6-1

---------------
pinta (1.6-1) experimental; urgency=medium

  * [5013a64] Require mono-addins 1.0, up from 0.6. (Closes: #728629)
  * [d4fb4b6] Revert "Update & finalise changelog". Accidently included
    applied patches.
  * [6de1a65] Imported Upstream version 1.6
    + Fixes Crop to Selection (LP: #1305701)
  * [6de8020] No need to require mono-addins-1.0 with pinta 1.6
  * [0cad737] Exclude MacOS modulerefs, these are conditionally enabled
  * [6f81146] Add a dllmap for Pinta.Core.dll

 -- Iain Lane <email address hidden> Thu, 12 Mar 2015 10:36:38 +0000

Changed in pinta (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Rolf, or anyone else affected,

Accepted pinta into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pinta/1.3-3ubuntu0.14.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in pinta (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Rolf Leggewie (r0lf) wrote :

Thanks, Raof!

I'm happy to see pinta making good progress here in Debian, Ubuntu and upstream. I'm happy to report that this issue is fixed in trusty-proposed.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pinta - 1.3-3ubuntu0.14.04.2

---------------
pinta (1.3-3ubuntu0.14.04.2) trusty-proposed; urgency=medium

  * fix the crop to selection. LP: #1305701
 -- Rolf Leggewie <email address hidden> Mon, 02 Mar 2015 15:55:16 +0800

Changed in pinta (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Adam Conrad (adconrad) wrote : Update Released

The verification of the Stable Release Update for pinta has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in pinta (Debian):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.