Comment 2 for bug 156636

Revision history for this message
Colin Watson (cjwatson) wrote :

Somebody really needs to submit this patch upstream. It's pretty massive and I can't find any mention of it on openssh-unix-dev at all. It also adds new configuration options; I've been bitten in the past by integrating third-party patches that upstream then chooses to integrate using different option names, and so I now have a general policy of not integrating patches that add configuration options in order to avoid having to carry any more compatibility code around until the end of time. (I have made the occasional exception for ones that have been quite thoroughly discussed upstream and are gradually being merged, such as the Kerberos patch.)

I have no objection to the patch as such (not having read it in enough detail), but in my experience adding this sort of OpenSSH patch just to distros and not upstream is asking for trouble down the line and I'd rather avoid it.