Comment 15 for bug 1786179

Fix V:
 - drop virtlogd sysV script (to fix the original issue) and drop the dh_systemd__start call to
   libvirtd (to avoid the secondary issue)
 - Intention: libvirtd (re)start is taken care of by dh_installinit anyway, avoid the bad restarts
   on virtlogd with this tweak
 - with that it seems to work, but it might have other implications that I missed
   - the new virtlogd-admin.socket is down (as it would need to restart the service)
   - service itself is up and still has the old PID so all is good
   - installation works, no more breaking the upgrade.

I'll add this finding to the Debian report to get their opinion on all of this

Upgrade output with that:
Setting up libvirt-daemon-system (4.6.0-1ubuntu1~ppa8) ...
Installing new version of config file /etc/apparmor.d/abstractions/libvirt-qemu ...
Installing new version of config file /etc/apparmor.d/usr.sbin.libvirtd ...
Installing new version of config file /etc/default/libvirt-guests ...
Installing new version of config file /etc/libvirt/libvirtd.conf ...
Installing new version of config file /etc/libvirt/libxl.conf ...
Installing new version of config file /etc/libvirt/qemu.conf ...
Installing new version of config file /etc/libvirt/virtlockd.conf ...
Installing new version of config file /etc/libvirt/virtlogd.conf ...
Created symlink /etc/systemd/system/sockets.target.wants/virtlockd-admin.socket → /lib/systemd/system/virtlockd-admin.socket.
Created symlink /etc/systemd/system/sockets.target.wants/virtlogd-admin.socket → /lib/systemd/system/virtlogd-admin.socket.
virtlockd.service is a disabled or a static unit, not starting it.
virtlogd.service is a disabled or a static unit, not starting it.
Job for virtlogd-admin.socket failed.
See "systemctl status virtlogd-admin.socket" and "journalctl -xe" for details.
Removing obsolete conffile /etc/init.d/virtlogd ...
Setting up libvirt-daemon dnsmasq configuration.
Setting up libvirt-daemon-driver-storage-rbd (4.6.0-1ubuntu1~ppa8) ...
Processing triggers for libc-bin (2.27-3ubuntu1) ...

RC is 0

Status check after upgrade:

● virtlogd.service - Virtual machine log manager
   Loaded: loaded (/lib/systemd/system/virtlogd.service; indirect; vendor preset: enabled)
   Active: active (running) since Fri 2018-08-10 11:21:55 UTC; 56s ago
     Docs: man:virtlogd(8)
           https://libvirt.org
 Main PID: 3191 (virtlogd)
    Tasks: 2 (limit: 4915)
   CGroup: /system.slice/virtlogd.service
           └─3191 /usr/sbin/virtlogd

Aug 10 11:22:50 c2 systemd[1]: virtlogd.service: Failed to reset devices.list: Operation not permitted
Aug 10 11:22:50 c2 systemd[1]: virtlogd.service: Failed to reset devices.list: Operation not permitted

● virtlogd.socket - Virtual machine log manager socket
   Loaded: loaded (/lib/systemd/system/virtlogd.socket; enabled; vendor preset: enabled)
   Active: active (running) since Fri 2018-08-10 11:21:55 UTC; 56s ago
   Listen: /var/run/libvirt/virtlogd-sock (Stream)
   CGroup: /system.slice/virtlogd.socket
Failed to dump process list, ignoring: No such file or directory

Aug 10 11:21:55 c2 systemd[1]: Listening on Virtual machine log manager socket.

● virtlogd-admin.socket - Virtual machine log manager socket
   Loaded: loaded (/lib/systemd/system/virtlogd-admin.socket; enabled; vendor preset: enabled)
   Active: inactive (dead)
   Listen: /var/run/libvirt/virtlogd-admin-sock (Stream)

Aug 10 11:22:50 c2 systemd[1]: virtlogd-admin.socket: Socket service virtlogd.service already active, refusing.
Aug 10 11:22:50 c2 systemd[1]: Failed to listen on Virtual machine log manager socket.

● virtlockd.service - Virtual machine lock manager
   Loaded: loaded (/lib/systemd/system/virtlockd.service; indirect; vendor preset: enabled)
   Active: inactive (dead)
     Docs: man:virtlockd(8)
           https://libvirt.org

● virtlockd.socket - Virtual machine lock manager socket
   Loaded: loaded (/lib/systemd/system/virtlockd.socket; enabled; vendor preset: enabled)
   Active: active (listening) since Fri 2018-08-10 11:21:55 UTC; 57s ago
   Listen: /var/run/libvirt/virtlockd-sock (Stream)
   CGroup: /system.slice/virtlockd.socket
Failed to dump process list, ignoring: No such file or directory

Aug 10 11:21:55 c2 systemd[1]: Listening on Virtual machine lock manager socket.

● virtlockd-admin.socket - Virtual machine lock manager admin socket
   Loaded: loaded (/lib/systemd/system/virtlockd-admin.socket; enabled; vendor preset: enabled)
   Active: active (listening) since Fri 2018-08-10 11:22:50 UTC; 2s ago
   Listen: /var/run/libvirt/virtlockd-admin-sock (Stream)
   CGroup: /system.slice/virtlockd-admin.socket
Failed to dump process list, ignoring: No such file or directory

Aug 10 11:22:50 c2 systemd[1]: Listening on Virtual machine lock manager admin socket.

● libvirtd.service - Virtualization daemon
   Loaded: loaded (/lib/systemd/system/libvirtd.service; enabled; vendor preset: enabled)
   Active: active (running) since Fri 2018-08-10 11:22:50 UTC; 1s ago
     Docs: man:libvirtd(8)
           https://libvirt.org
 Main PID: 4544 (libvirtd)
    Tasks: 19 (limit: 32768)
   CGroup: /system.slice/libvirtd.service
           ├─3462 /usr/sbin/dnsmasq --conf-file=/var/lib/libvirt/dnsmasq/default.conf --leasefile-ro --dhcp-script=/usr/lib/lib…er
           ├─3463 /usr/sbin/dnsmasq --conf-file=/var/lib/libvirt/dnsmasq/default.conf --leasefile-ro --dhcp-script=/usr/lib/lib…er
           └─4544 /usr/sbin/libvirtd

Aug 10 11:22:50 c2 libvirtd[4544]: 2018-08-10 11:22:50.914+0000: 4656: error : virPCIDeviceConfigOpen:307 : Failed to op…le system
Aug 10 11:22:50 c2 libvirtd[4544]: 2018-08-10 11:22:50.914+0000: 4656: error : virPCIDeviceConfigOpen:307 : Failed to op…le system
Hint: Some lines were ellipsized, use -l to show in full.