Debian
lesstif1-1 package

  1. Bug #12635
  2. Comment #17

Comment 17 for bug 12635

Revision history for this message
In , Matej Vela (vela) wrote : Re: backported fix for lesstif1

tag 294099 patch
thanks

On Fri, May 06, 2005 at 10:14:41PM +0300, Kimmo Jukarainen wrote:
> I have made a backport of CAN-2004-0914 and CAN-2005-0605 fixes for
> lesstif1 available at
>
> http://www.inside.org/~kimju/src/lesstif/
>
> It compiles, but is currently untested. Please review and/or test
> before using.
>
> Please feel free to send any comments about this patch to me.

Nice work!

I tried comparing the diffs side by side, but found it too mind-numbing, so
I went and applied the original patches independently on the premise that
we're unlikely to both make a mistake in the same place.

The result of diffing the diffs (and fixing my own numerous screwups :-) is
at <http://people.debian.org/~vela/>. The changes are as follows:

 * Re-added various comments and extraneous whitespace introduced by the
   original patches, to provide context for future backports.
 * Removed duplicate `#include <sys/types.h>'.
 * _LtxpmHashTableInit: Fixed typo in LessTif's port (s/+=/>=/).
 * _LtxpmParseValues: A part of the CAN-2004-0687-0688 patch wasn't
   applied (s/BUFSIZ/& + 1/).
 * OpenReadFile: Removed two leftover lines.

If you're okay with the above, I can do an NMU.

Thanks!

Matej