Debian
gnucash package

  1. Bug #365065
  2. Comment #40

Comment 40 for bug 365065

Revision history for this message
In , Christian Stimming (stimming-deactivatedaccount) wrote :

I'd like to see some action with this patch.

@Charles: (In reply to comment #20)
> It doesn't check for the book closing
> indicator (which was added after the patch was written).

Could you add support for that? gnucash 2.2.8 (December 2008) and later have that indicator, so at some point in time we can assume enough users will have it in their file.

> Otherwise we'd have to make the conversion completely optional (pop up a
> question if posting times other than 00:00 are found in the file), which this
> patch doesn't do either.

Could you add support for that as well? We should at least be able to fix this issue for users who didn't use the book closing, or used it only with 2.2.8 and higher. We can leave the implementation of a druid for later.

Once this two additional points are added, I would like to commit this patch to have it in 2.4.0.

Re comment#21: Please go through the full discussion here https://lists.gnucash.org/pipermail/gnucash-devel/2008-August/023757.html ; what you are proposing ("use the date part and ignore the rest") is basically saying we have a date data type in contrast to a date-and-time data type, which was also discussed there.