Comment 5 for bug 2042356

Revision history for this message
Miriam EspaƱa Acebal (mirespace) wrote :

Hi Sudip!

I reviewed the patch, and I have a few questions:

- The patch seems to be one of the commits of the MR accepted on Debian on 976439 (the last one in fact). Would the commit a7ac2dbdc122115b5603f595c56cc55a6f09dca3 "Also add libwiicd patches. " be needed?

- The patch is for commit https://salsa.debian.org/georgesk/cwiid/-/blob/e7cebe40c94b05e97f07302c36e93f60482b0ae5/debian/patches/python3-build-azzra, but is not completely imported:
   - Makefile.in is not imported in the patch (maybe is this related to the commit a7ac2db (the one I pointed to in the previous question?)
   Why are some parts of the original commit (change comments, e.g.) not imported into the patch?

Could you give us more information about this elections?

I build the package with the patch (it builds OK) and I didn't test yet