Comment 1 for bug 111719

Daniel,

working on this I stumbled against a little problem for which I need your advise.

Compilation fails at line 793 of mcd-connection.c:
warning: passing argument 3 of 'g_file_get_contents' from incompatible pointer type

Since one of the compilation flags is -Werror, warnings are treated as erros and compilation fails.

Indeed, line 793 is:

g_file_get_contents (filename, &avatar->data, &avatar->len, &error)

In the Glib manual, argument 3 should be gsize (which is typedefined as an unsigned int) and avatar->len is declared as guint (also typedefined as an unsigned int).

What of these do you think I should do:

- patch the source, or
- disable the Werror directive, or
- disable the strict pointer type checking