Comment 24 for bug 587597

Pardon me, but I was not arguing against DC++ naming standards, I was simply stating my reasons for naming them the way I did. Besides (if it is decided that this gets into DC++) you don't need me to change some capitalisations, anyone can do that since I won't be the one putting it in anyways as I don't have any access to the repository.

Regarding the ACP stuff I do see your point and that is easy to sort out. But if the API provides text conversions it is only logical to provide utf-8 to wide char conversion as well if unix does not need this then it's no-ones loss.

Regarding your comment about onOutgoingChat, sure that might be partly true but the idea of onOutgoingChat & co. is to allow plugins to react to outgoing chat before UI does anything with it. If you want it is easy enough to change it to something like onPreprocessChat and move the hook event(s) under the UI hook id.

One scenario that mandates onOutgoingChat be called from UI is the case where plugin wants to extend an existing client side command for example (/help being the first one that comes to mind).

There are some other things that have come up in recent(ish) discussions about the implementation anyways, so I'll be updating the patch soon.