Comment 6 for bug 316096

Revision history for this message
Jan Vidar Krey (janvidar) wrote :

Fredrik, that is totally missing the point.

This "extension", should explain where a connection originates from, but not primarily for a client's convenience, primarily for handling DDoS.

As I tried to explain above, a client is merely expected to ignore the extra support information when it is received. A client should deduce; I don't support the "Ref=dev.myhub.org:1234"-extension, so I'll just ignore it silently. That is what I described as phase 1 -- most clients, including DC++ is already compliant here.

The second phase is for the clients to actually send the extra information when it is connecting to a host, in order to indicate *where* the connection was initiated from. That's phase 2, and the actual work that needs to be done. It is totally OK if not every client has this extension, as long as *some* will send it, it is possible for whoever is attacked to get a clue about who is behind the "attacks" that have been going on for days (ask Toast!)

This solution provides a generic and simple way to communicate exactly that, and is much better than hardcoding this as copy-pasted from a dc++ patch:

+ protectedIPs.push_back("dcpp.net");
+ protectedIPs.push_back("hublist.org");
+ protectedIPs.push_back("hubtracker.com");
+ protectedIPs.push_back("dchublist.com");
+ protectedIPs.push_back("adchublist.com");
+ protectedIPs.push_back("adcportal.com");

Yes, these are the sites that have been down due to the problem this particular bug is proposing a fix for, can you imagine the time it takes for this patch to be merged into DC++, until enough people actually upgrade to it?
Let alone, at least one of those addresses are closed already...

My 2 cents.