Search doesn't save search exclusions to the dropdown search history list

[Diesel Grapes]

Summary says all the info, here's the steps to reproduce:

1. open search and type "Jimi Hendrix" w/o quotes
2. search "soul sessions -joss" w/o quotes
3. the dropdown list has now two items: "Jimi Hendrix" and "soul sessions" (w/o quotes again)

That's it. Pretty simple. No search exclusions saved.

DC++ 0.707
Win XP Pro SP2

[eMTee (realprogger)]

I think it behaves like that for serveral years. After starting a search it strips out all filter words (started with -) from the search string for displaying purposes, but it adds the stripped search string to the search history as well. I can't decide its really a bug or happens by purpose, but its probably better to keep the original text in the history...
If its a bug then the attached patch should solve this...

[Jacek Sieka (arnetheduck)]

I'd say it's a bug - it would be better if you saved the original string in a tmp variable instead of doing getText each time though,..

[eMTee (realprogger)]

There is an easier solution as the original string is in a tmp variable which is reused later for the stripped ones. So only moved the fill of the dropdown to a bit earlier...