Comment 8 for bug 238482

Revision history for this message
cologic (cologic) wrote :

It's been reported that, indeed, the patch previously does not work. I still cannot usefully test this, but I'll make one more attempt at simply a more thorough version of the above, addressing both points. It does translate / to \\ and it also wraps several more filepath-related Win32 API callsites in File.cpp and FileReader.cpp.

It still doesn't work on WINE 1.6.2; the test suite creates the following error console messages:
[----------] 1 test from testarchive
[ RUN ] testarchive.test_archive
U::gNP: test/data/out/gtest.h => \\?\test\data\out\gtest.h
U::gNP: test/data/ => \\?\test\data\
U::gNP: test/data/out/ => \\?\test\data\out\
U::gNP: test/data/out/gtest.h => \\?\test\data\out\gtest.h
F::F: test/data/out/gtest.h \\?\test\data\out\gtest.h
U::gNP: test/data/out/gtest.h => \\?\test\data\out\gtest.h
Thrown: FileException: Path not found.
test/testarchive.cpp:17: Failure
Failed
FileException: Path not found.
[ FAILED ] testarchive.test_archive (3 ms)
[----------] 1 test from testarchive (5 ms total)

U::gNP == Util::getNtPath and F::F is File::File. Removing the Util::getNtPath call from F::F does, in fact, allow the test suite to pass under WINE 1.6, but as far as I can tell, based on MSDN documentation, that filename translation is correct. Without the ability to test on my end, this is probably about as far as I can go.