Comment 1 for bug 1965620

Revision history for this message
eMTee (realprogger) wrote :

The committed fix https://sourceforge.net/p/dcplusplus/code/ci/5ffb7d83126d0ca6857c0f1e6fb4845653b65009/ is made to be probably the least invasive; it still mimics the logic of how it's done in AirDC++ as it stricly sets tlsext_host_name only for httpconnection and client outgoing connection attempts by saving the hostname before it gets resolved to IP.

Other possibly cleaner ways to doing this are
- sending the isURL parameter through the connect() members but that needs changes in the Socket class as well
- or maybe in place determine the address type in SSLSocket::connect() and save the hostname accordingly there
- or simply set tlsext_host_name to whatever comes in the address string and see whether it breaks other type of connections.