Comment 16 for bug 195209

Revision history for this message
poy (poy) wrote :

this patch changes the "Colors and sounds" settings page, in which the 2 check-boxes are replaced by a list-view with 3 options; "sound for main chat", "for PMs", "for when a PM window opens".
the sound selection field in the bottom stays the same, and is enabled only when a sound option is selected and checked (as in the "Logs" page).

i've tried to add the lowest possible number of settings added to SettingsManager: only 3 settings are used for sounds, 1 per event. each setting is either empty (no sound to play), "beep" (play the default "beep" sound), or a path to a sound file that the user has choosen in settings. that means each event can have a different sound.

after that, the following is left to make this feature request[s] fulfilled:
- Ctrl+Tab, Ctrl+Shift+Tab to switch between settings pages; not so important since the tree-view can be accessed through usual tabbing and then pages can be switched with keyboard arrows;
- accelerators in child windows, only the main window's accelerators are currently working.