what a nice patch! thanks, applied.
I especially liked the variadic template... ;)
- has anyting changed in the NMDC parsing part? hard to catch that from the patch.
- as I'm a bit rusty... could the "x[x.length() - 1] != 0x0a" check crash on empty data? it was after a "x.compare(1, 4, "RES ") == 0" check before your patch but that clause has been removed.
what a nice patch! thanks, applied.
I especially liked the variadic template... ;)
- has anyting changed in the NMDC parsing part? hard to catch that from the patch.
- as I'm a bit rusty... could the "x[x.length() - 1] != 0x0a" check crash on empty data? it was after a "x.compare(1, 4, "RES ") == 0" check before your patch but that clause has been removed.