Comment 36 for bug 409654

Ok, the code looks better, but still has issues:

Once the bait has been eaten, server.world.get_object() will return None for bait, so bait.id won't work. But you don't need to check for bait.id, as you already have self.bait_id.

Just to be safe you should also check if bait is not None before the loop which iterates over bait.contains, and also check both hook_id and hook, as those calls are not guaranteed to succeed.

With the latest code you just pushed, the Fishing task crashed, but I was able to confirm that the hook is object is inside a fish now, and the bait was eaten. What happened for you when you tried the code? Did you get the task crashing in the same place?