Comment 7 for bug 1734274
Revision history for this message
| Scott Moser (smoser) wrote Re: curtin fails to deploy on empty config values | #7 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0f7b58d
(Get the code!)
I had put up a merge proposal a while ago at
https:/
that covers this basic issue.
The preseeds files in /etc/ are quite non-trivial to edit.
My solution in that mp was to empty out the maas internal sections from there
as they're not really expected to be editable anyway.
If my merge proposal above was taken it would at least be more obvious to the user what they were writing in the config. Any complexity would have been their own additions.
From curtin's perspective it got garbage config. early_commands is supposed to be a dictionary. There are a few different things curtin could do to improve the situation:
a.) provide a schema or other mechanism for config validation that maas could use. That would allow maas to provide the user with an earlier error.
b.) explicitly allow <stage>_commands entries to be None.
c.) give a better error.
'b' sounds reasonable, but I suspect would have just resulted in the user not getting the result they were looking for. The install may have finished but just not done what they wanted.