> This isn't right. Functions shouldn't generally unref passed in parameters as
> a side effect.
I’m pretty sure I needed to do it that way, because ck_session_leader_collect_parameters stashes the callback and the leader away in the pending_jobs queue rather than running the callback immediately. With your modified version of my patch that you committed, is there anything to prevent the leader from being freed while the job is still in the queue?
> This isn't right. Functions shouldn't generally unref passed in parameters as
> a side effect.
I’m pretty sure I needed to do it that way, because ck_session_ leader_ collect_ parameters stashes the callback and the leader away in the pending_jobs queue rather than running the callback immediately. With your modified version of my patch that you committed, is there anything to prevent the leader from being freed while the job is still in the queue?