Comment 15 for bug 232557

Revision history for this message
In , William Jon McCann (william-jon-mccann) wrote :

Review of attachment 37533:

Thanks for tracking these down! The review tool doesn't cope very well with having two different patches for the same file apparently so I'm not sure this review will look as intended. Apart from the unref issues I mentioned this looks good.

::: src/ck-manager.c
@@ +1256,1 @@
 }

This isn't right. Functions shouldn't generally unref passed in parameters as a side effect.

@@ +1273,1 @@
 }

Also not right for the same reason.

@@ +1287,3 @@
         log_seat_session_removed_event (manager, seat, ssid);
+
+ g_free (ssid);

We don't need to take a new ref here since we already have one in this context.