1 Use separate .disp file for display type, remove display-types.conf
install .disp files to /etc/ConsoleKit/displays.d/,
each .disp file represent a display type.
2 Only use Command in .disp file, remove Arguments/UseAuth/Chooser/Priority
3 Remove priority code
4 When adding/removing displays, CK should emit signal instead of
calling GDM method directly
For org.freedesktop.ConsoleKit.Seat
add signal SessionToAdd and SessionToRemove
add method ManageSeat
For org.freedesktop.ConsoleKit.Manager
remove method CreateStaticSessions
add method GetUnmanagedSeats
5 Use a{sv} for dbus method CreateDisplay, since
task #2 is done, there are only two parameters need to be send with
signal, this work is not necessary
6 Rewrite ck-dynamic to reflect change in task #4
7 Rewrite ck_display_type_new()
8 Remove method org.freedesktop.ConsoleKit.Manager.ListCreatedSessions.
Let ck-dynamic do the GetSeats() and filtering dynamic displays itself
9 make ck_seat_add_display(), ck_seat_set_display_type() and ck_seat_get_displ
return a gbooolean
10 Remove unused create_display_with_parameters()
11 Comments should appear before the lines they're commenting on, not after.
12 Reverse Name and Version back
13 Figure out X11_DIR from pkg-config
This patch is reworked under branch multi-seat by commit 25145f35ab527a2219604e1710eb65e2178f6978
Created an attachment (id=26451)
reworked patch after Ray's review on CK's patch
There are multiple changes which are based on review by Ray Strode, mail.gnome. org/archives/ gdm-list/ 2009-May/ msg00007. html
http://
1 Use separate .disp file for display type, remove display-types.conf /displays. d/, UseAuth/ Chooser/ Priority .ConsoleKit. Seat .ConsoleKit. Manager sions type_new( ) .ConsoleKit. Manager. ListCreatedSess ions. add_display( ), ck_seat_ set_display_ type() and ck_seat_get_displ display_ with_parameters ()
install .disp files to /etc/ConsoleKit
each .disp file represent a display type.
2 Only use Command in .disp file, remove Arguments/
3 Remove priority code
4 When adding/removing displays, CK should emit signal instead of
calling GDM method directly
For org.freedesktop
add signal SessionToAdd and SessionToRemove
add method ManageSeat
For org.freedesktop
remove method CreateStaticSes
add method GetUnmanagedSeats
5 Use a{sv} for dbus method CreateDisplay, since
task #2 is done, there are only two parameters need to be send with
signal, this work is not necessary
6 Rewrite ck-dynamic to reflect change in task #4
7 Rewrite ck_display_
8 Remove method org.freedesktop
Let ck-dynamic do the GetSeats() and filtering dynamic displays itself
9 make ck_seat_
return a gbooolean
10 Remove unused create_
11 Comments should appear before the lines they're commenting on, not after.
12 Reverse Name and Version back
13 Figure out X11_DIR from pkg-config
This patch is reworked under branch multi-seat by commit 25145f35ab527a2 219604e1710eb65 e2178f6978