Comment 4 for bug 1227449

Revision history for this message
MC Return (mc-return) wrote :

Daniel, thanx a lot 4 your patch. Looks good to me at first glance.

You do not need the brackets, if there is just one statement in the if condition/for loop though, but that is a minor coding style issue only...
Not sure about boost::shared_ptr and I am also not a shader expert, but I would say: "If your patch fixes the leaks without crashing the shader, all should be good." ;)
I will test your patch and report back, although I am not sure, if I am able to reproduce the leaks as just the "Negative" plugin seems to use GLWindow::addShaders.

If you have an improved version in the meantime, do not hesitate to post it here.