Comment 5 for bug 1302098

Revision history for this message
Jing Wang (prepangolin) wrote :

- Disable cascadeFindFirstFit
The cause of segfault, so reference to null pointer
std::sort (belowSorted.begin(), belowSorted.end(), compareTopmost);
I got the log message using compLogMessage() function.
You can got the message in console, to do this, type #compiz --replace ccp

- Fixed to cascadeFindNext function
If we go off the screen, start over with a new cascade.
I fixed to error condition: cascadeY + winHeight > workArea.bottom()
There was an logical error on calculating of window position(x,y)
e.g. 465+434 > 900 in this case: error occured(no next to cascade)

In my opinion, First, cascadeFindFirstFit function was not completed, so useless
Second, my patch is tricky, so need to improve.
Good review for this patch would be welcome!