Comment 17 for bug 878516

Revision history for this message
Sami Jaktholm (sjakthol) wrote : Re: Restoring a grid-placed window by dragging the title bar downwards does not restore the original window width

The problem is only happening when the window is maximized to the Left or Right edge. If you place a window to for example top left, or bottom, the window is resized correctly after it's snapped away from its position.

Grid leaves the unmaximation to some other component and that doesn't restore the width which was changed prior to maximation (my guess is that it saves the window state after grid has changed the width) . Easy workaround would be to resize (and reposition, the position is also wrong if unmaximized via window controls) the window in GridWindow::stateChangeNotify when window is unmaximized. However this would complicate things even more as there's now two parts of the code which handle resizing and repositioning (one for normal restore, another for restore from maximized state).

While debugging this, I found many other bugs (I'll open separate reports about those). IMO the window handling parts of the grid plugin should be completely rewritten instead of relying on ugly hacks to fix these bugs. Working around them would be hard and it will make make the code even more complicated than needs to be and thus might cause some other problems in the future...