Comment 10 for bug 150360

Thanks for the feedback, see my comments below:

> "Show online clients of a contact" option:
> * When the patch is just enabled, this option is unchecked. However, the different resources *are* shown.
> * I don't think there should be an option for this. At least not in the GUI. There may be a config file option. This feature should > be enabled by default.
Hrm, yes, I don't know where this again comes from... I had this working before.
Because it should be enabled by default, how about removing this as a configuration option at all?
I'd remove the configuration option from the GUI, and also in the code and always assume that there are probably multiple resources in the tree.
That would make the code much simpler to write, no need to distinguish. Its complicated enough ;)

> Contacts *always* should be collapsed; the resources should be hidden under a + sign after login.
OK, this I have done now in my working tree, the next patch will default to collapsed.
When there are already resources listed, and the tree is open, and another resource comes online, it will stay open.

> There still seems to be an issue with presence. For instance, for one contact which is "busy", both resources show the "busy" > icon whilst the bare JID icon shows the "available" icon. The balloon text also shows "available".
I need to figure out why this happens, and how to prevent that. No idea yet.

> If a contact with 2 online resources, logs of 1 resource, there is only 1 subitem. It would be more clean to simply remove the + > sign when only 1 resource is left.
I thought I do this already, but somehow after a bit of rework, it seems to not do this anymore, will take a look, as I fully agree and also planned to do so.

> I don't think the chat submenu is still needed in the RMB context menu.
OK, I can remove it entirely, when clicking on a contact, then chat is always stated to the jid2, when clicking on a resource, then to a jid2 as it is right now when you click the chat button on top or double click (with chat opens instead of a new message)

> I am not sure whether contact actions should be possible to set on resource level. This may cause usability issues. What do you think?
Good point, I did not thought about that yet. So only enable the menu entry on a contact. You mean when clicking on a resource it should be disabled?
Should be possible.

> How do you sort the resources? I would suggest first sorting on presence status, then priority, and then alphabetically.
Not yet actually ;) I need to figure out an easy way to do so, I'll keep the order you propose in mind.

> Not all styles seem to work very well. Is this still on your TODO list?
I only wanted to put multiple resources of a contact in the tree below the contact for the Plain and TwoLines styles, the others are rather flat, so just putting the multiple contacts flat next to each other.
Or also introducing the tree there? I think that would not look very nice.

Not yet tested:
* sending and receiving messages
* file transfer
* whiteboard sessions
* partially tested: roster styles.