Comment 20 for bug 149805

Revision history for this message
sander (s-devrieze) wrote : Re: [Bug 149805] Re: Enable the new presence control panel

>> * always show the icon to show the connection security indication
> (low/medium/high). In toy-status, this should be on the same line as the
> open/hide panel button
>
> Done, but I have no medSecure icon in Crystal.

That's why I sent you the Oxygen icon set ;-)

PS: when you added Oxygen to svn, remove the Crystal set and sent it
to me so that I can update it.

<snip>
>> * some activity icons can be found here:
> http://trac.gajim.org/browser/trunk/data/activities
>
> Added all to cvs and code.

PS: I read in the commit logs that the Gajim people will add more
activity icons. So you might want to check it again in a few weeks for
updates.

>> * when removing an entry in toy-status, the other entries should be
> outlined again
>
> ?

When you remove the Mood block for instance, there is a large gap.

>> * in toy-status, the mouseover icon maybe should be an icon pointing
> down or up depending on whether or not the panel is opened
>
> You mean instead of the coccinella?

Yes, but it's only showed on mouseover. When the mouse is not on the
button, you still see the ladybug.

>> * in toy-status the menu icon should be 16x16 sized or 22x22 sized
>>
>
> ?

== The ladybug icon.

> There are stil many fixes to the toy-status/slots/megapresence but
> will continue tomorrow.

You introduced a bug:

can't read "myMoods": no such variable
    while executing
"foreach mood $myMoods {
        $m add radiobutton -label [mc $mood2mLabel($mood)] -value
$mood -image [::Theme::FindIconSize 16 mood-$mood] -variable
[nam..."
    (procedure "MPBuild" line 19)
    invoked from within
"MPBuild .jmain.f.logo.mp.1.box.1"
    (in namespace inscope "::Mood" script line 1)
    invoked from within
"::namespace inscope ::Mood MPBuild .jmain.f.logo.mp.1.box.1"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 $widgets($name,cmd) $box.$column"
    (procedure "Build" line 55)
    invoked from within
"Build .jmain.f.logo.mp.1"
    (in namespace inscope "::MegaPresence" script line 1)
    invoked from within
"::namespace inscope ::MegaPresence Build .jmain.f.logo.mp.1"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 $slot($name,cmd) $w.$row"
    (procedure "SlotBuild" line 13)
    invoked from within
"SlotBuild $wmp"
    (procedure "::JUI::Build" line 166)
    invoked from within
"::JUI::Build $wDlgs(jmain) "
    (procedure "::Jabber::Init" line 38)
    invoked from within
"::Jabber::Init"
    (file "Coccinella.tcl" line 322)

> However, there are many fine details fixed/added which is not so easy to see.
> Note the mood and activity in the mega presence slot. Cool!

I only see Coccinella not starting for the moment :-)