Dan, I reviewed the nova change eventually and I found no problem (maybe we would need some unit tests for the upstream change, but this is fine for the moment).
About the fact that we don't know the disk_format and then we need to call again Glance for getting it, I see it in the change, but maybe we could try to automatically detect the format, as we already have detect_file_format() ?
If we would then create a new config knob, maybe we could ask whether the operator would prefer to call Glance or testing every format ?
Dan, I reviewed the nova change eventually and I found no problem (maybe we would need some unit tests for the upstream change, but this is fine for the moment).
About the fact that we don't know the disk_format and then we need to call again Glance for getting it, I see it in the change, but maybe we could try to automatically detect the format, as we already have detect_ file_format( ) ?
If we would then create a new config knob, maybe we could ask whether the operator would prefer to call Glance or testing every format ?