Comment 129 for bug 2059809

Revision history for this message
Pavlo Shchelokovskyy (pshchelo) wrote : Re: Arbitrary file access through QCOW2 external data file (CVE-2024-32498)

hi all, couple of very minor problems noted with patches that were sent out:

glance
- 4 patches in a series, seems like two vmdk-related unit tests from patch 3 leaked into patch 2, thus patch 2 on its own can't pass CI
- patch 4 has flake8 problem in test_image_conversion.py on line 210 - missing empty line

nova
- second of two patches has problems with autopep8 in format_inspector.py, four missing empty lines detected.

Nothing major, but better to be fixed before the disclosure date so that we do not spend time fixing it on CI :-)