Comment 1 for bug 1358317

The click-reviewers team discussed and we feel that marking this as a warning is too much. The majority of existing apps use a .json extension since that is what the SDK did and documentation recommended, and some people may choose not to use the SDK to develop click packages. The file extension doesn't actually matter-- the file just needs to be parseable json and then the security checks are run.

That said, I think the check is valid and useful for the SDK. I will be updating the click-reviewers-tools to retain the check, but mark is as 'info'. This means that the check won't block acceptance in the store, it supports existing apps and documention and supports users not using the sdk, but allows the sdk to look at the 'info' json and flag it within the sdk.

Here is example output:
$ ./bin/click-review --sdk <path/to/click>
= lint =
{
  "error": {},
  "info": {
...
    "lint_sdk_security_extension_foo": {
      "manual_review": false,
      "text": "foo.json does not end with .apparmor (ok if not using sdk)"
    },
...
  "warn": {}
}