commit 1b21d499bb3bb1e94e2815cbada86db8e8e21406
Author: John Griffith <email address hidden>
Date: Wed Jun 11 22:43:41 2014 +0000
Remove global conf settings from iscsi helper
This "intermediate" iscsi helper pulls all of it's
config settings from the global config. This is fine
if you only have a single backend, but if you do
multi-backend it puts things in a bad state where some
of the backend specific settings are picked up but
others are not (for example iscsi_ip_address).
This change modifies methods like create_export in
the volume/iscsi helper to take the drivers version
of the config settings as a parameter and use those
instead of setting off of the global values.
Long term there's a lot of cleanup surrounding our
inheritance model and especially the iscsi helpers.
We can address that going forward but here we just want
to fix the bug in the safest way possible.
Reviewed: https:/ /review. openstack. org/99501 /git.openstack. org/cgit/ openstack/ cinder/ commit/ ?id=1b21d499bb3 bb1e94e2815cbad a86db8e8e21406
Committed: https:/
Submitter: Jenkins
Branch: master
commit 1b21d499bb3bb1e 94e2815cbada86d b8e8e21406
Author: John Griffith <email address hidden>
Date: Wed Jun 11 22:43:41 2014 +0000
Remove global conf settings from iscsi helper
This "intermediate" iscsi helper pulls all of it's
config settings from the global config. This is fine
if you only have a single backend, but if you do
multi-backend it puts things in a bad state where some
of the backend specific settings are picked up but
others are not (for example iscsi_ip_address).
This change modifies methods like create_export in
the volume/iscsi helper to take the drivers version
of the config settings as a parameter and use those
instead of setting off of the global values.
Long term there's a lot of cleanup surrounding our
inheritance model and especially the iscsi helpers.
We can address that going forward but here we just want
to fix the bug in the safest way possible.
Change-Id: If17ec3ffb3f4ea 7f95da65781885d cd613b1a807
Closes-Bug: 1325799