Tests require python-oauth2client
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Confirmed
|
Undecided
|
Unassigned | ||
cinder (Ubuntu) |
Fix Released
|
High
|
Adrien Nader |
Bug Description
Cinder has implemented support for both oauth2client and google-auth. However, tests still require oauth2client.
The affected file is cinder/
from oauth2client import client
[...]
I've tried alternatives but a) I'm not familiar enough with the codebases to be entirely confident about them, b) the codepath has not been taken during my tests and I therefore had no way of verifying my changes.
Considering the codepath appears to not be taken during normal operation, a generic Exception seems acceptable to me, at least in the short term. I plan on preparing such a chance soon in order to fix current cinder builds.
Changed in cinder (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Adrien Nader (adrien) |
importance: | Undecided → High |
milestone: | none → ubuntu-24.10 |
Changed in cinder: | |
status: | New → Confirmed |
Changed in cinder (Ubuntu): | |
status: | In Progress → Fix Committed |
And something related.
The commit visible at https:/ /opendev. org/openstack/ cinder/ commit/ 7509ad4fb6f4b6d a959868179b98b8 6f0059979b introduced a change which I think is buggy as it uses 'client.Error' in the codepath where 'client' is None due to oauth2client not being imported.