Tests require python-oauth2client

[Adrien Nader]

Cinder has implemented support for both oauth2client and google-auth. However, tests still require oauth2client.

The affected file is cinder/tests/unit/backup/fake_google_client.py . It does the following:

    from oauth2client import client
    [...]
                raise client.Error

I've tried alternatives but a) I'm not familiar enough with the codebases to be entirely confident about them, b) the codepath has not been taken during my tests and I therefore had no way of verifying my changes.

Considering the codepath appears to not be taken during normal operation, a generic Exception seems acceptable to me, at least in the short term. I plan on preparing such a chance soon in order to fix current cinder builds.

[Adrien Nader (adrien)]

And something related.

The commit visible at https://opendev.org/openstack/cinder/commit/7509ad4fb6f4b6da959868179b98b86f0059979b introduced a change which I think is buggy as it uses 'client.Error' in the codepath where 'client' is None due to oauth2client not being imported.

[Takashi Kajinami (kajinamit)]

oauth2client IS still required because it's in requirements.txt . It's not actually used by logic code if recent google api client is installed but it has been left without any appropriate cleanup.

There is a work to remove usage of oauth2client in master https://review.opendev.org/c/openstack/cinder/+/902120 .
Once that is merged then we can get rid of oauth2client.

[Adrien Nader (adrien)]

Thanks for your very quick answer. I wasn't aware of that review which looks very interesting.

I should have mentioned I'm looking at this from a Ubuntu packaging perspective. Right now I have an issue because the oauth2client dependency is causing troubles: it uses APIs that have been removed from pyopenssl and I don't want to try to reimplement or work-around anything close to PKCS#12. My goal is therefore to drop the python-oauth2client package from the distribution.

Do you think your patch can be cherry-picked to the Ubuntu package? That would help tremendously.

[Launchpad Janitor (janitor)]

This bug was fixed in the package cinder - 2:24.0.0-0ubuntu3

---------------
cinder (2:24.0.0-0ubuntu3) oracular; urgency=medium

  * Remove use of python-oauth2client (LP: #2073242):
    - 8fb2b35.diff: remove logic for google-api-python-client < 1.6.0
    - d71530c.diff: remove unused fallback to oauth2client

 -- Adrien Nader <email address hidden> Tue, 23 Jul 2024 15:19:19 +0200